-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Python 3.10 #1989
Update to Python 3.10 #1989
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## elizabeth/update-python-and-dependencies #1989 +/- ##
============================================================================
- Coverage 75.62% 75.55% -0.07%
============================================================================
Files 133 133
Lines 24628 24628
============================================================================
- Hits 18625 18608 -17
- Misses 6003 6020 +17 ☔ View full report in Codecov by Sentry. |
Template (manual test)Backwards compatibilitypip freezemamba listTraining/Inference via GUITraining Dialogsleap-labelInstallationpip freezemamba list |
Mac (manual test)Fails on training with leaked semaphore:
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
53ce002
into
elizabeth/update-python-and-dependencies
Description
This PR has evolved quite a bit over the course of troubleshooting dependencies.
It now has a working recipe that enables updating to Python 3.10 across platforms.
Key insights from last round of troubleshooting:
LoadImageWorker
/QtVideoPlayer
correctly. This is now done using signals and slots so that state lifecycle is managed in thread-local functions. We might still not handle cleanup correctly in all cases (e.g., visualizer during training), but everything is working now other than some stray error messages from a subprocess.Old description
Description
This PR skips the attempted previous prerelease of 1.4.1a3 (that does no bumpy the python version). But, we were running into trouble with conflicting
h5py
packages on the WIndows build manual test. So, here we are - releasing what was intended to be 1.4.1a4 as 1.4.1a3.Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️